Issue Navigator #2006
Open
Issue Navigator #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the Issue Navigator sidebar, which displays code errors and warnings. Key changes include:
- Adding a new IssueNavigatorViewModel and associated data structures for managing diagnostics.
- Integrating new Issue Navigator UI components into the NavigatorArea.
- Updating the LSP service and WorkspaceDocument to support the new issue tracking.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CodeEdit/Features/NavigatorArea/Views/NavigatorAreaView.swift | Adds an "issues" tab to the navigator tabs. |
| CodeEdit/Features/NavigatorArea/ViewModels/IssueNavigatorViewModel.swift | Introduces the view model and supporting functions for issues. |
| CodeEdit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorViewController+NSOutlineViewDelegate.swift | Improves comment clarity. |
| CodeEdit/Features/NavigatorArea/OutlineView/StandardTableViewCell.swift | Removes a duplicate subview addition of the icon. |
| CodeEdit/Features/NavigatorArea/OutlineView/IssueTableViewCell.swift | Adds a custom table view cell for rendering issue nodes. |
| CodeEdit/Features/NavigatorArea/Models/NavigatorTab.swift | Adds new case .issues with associated icon and label. |
| CodeEdit/Features/NavigatorArea/IssueNavigator/... (various files) | Implements the UI for the Issue Navigator via view controllers, data sources, and a SwiftUI wrapper. |
| CodeEdit/Features/LSP/Service/LSPService.swift & LSPService+Events.swift | Updates LSP service APIs to include workspace info and event handling. |
| CodeEdit/Features/LSP/LanguageServer/LanguageServer.swift | Adds workspace context to the language server. |
| CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift | Instantiates the issue navigator view model with a hardcoded project name. |
Comments suppressed due to low confidence (1)
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift:37
- The IssueNavigatorViewModel is initialized with a hardcoded project name "Test". Consider retrieving the actual project name from the root folder to avoid hardcoding.
var issueNavigatorViewModel: IssueNavigatorViewModel? = IssueNavigatorViewModel(projectName: "Test")
FastestMolasses
added
UI
FastestMolasses
requested review from
austincondiff,
thecoolwinter and
tom-ludwig
thecoolwinter
requested changes
Jun 19, 2025
CodeEdit/Features/NavigatorArea/IssueNavigator/OutlineView/IssueNavigatorViewController.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/IssueNavigator/OutlineView/IssueNavigatorViewController.swift
Outdated
Show resolved
Hide resolved
thecoolwinter
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Looks good! I am struggling to test it consistently with a real language server, but not because of the components you've added here. I think we may need to add a call to the pull diagnostics server capability to round out the diagnostics fetching, but I say lets add an issue for that and come back to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Issue Navigator side menu to allow users to see the errors and warnings in their codebase.
Related Issues
Checklist
Screenshots